From 92791a3fe15bb2d5c14039fbd531be73255f0c6d Mon Sep 17 00:00:00 2001 From: Ulf Magnusson Date: Sat, 1 Jun 2019 04:15:04 +0200 Subject: Fix obscure crash with rsource and $srctree pointing to a symlink Sourcing a file with an absolute path and using rsource in it triggered a relpath() between the absolute path and $srctree. Since e.g. symlink/../bar/ = bar/ is not guaranteed for symlinks, this could lead to the rsource'd file not being found if $srctree pointed to a symlink. Switch to a simpler, more textual method for stripping $srctree from glob results, which should be robust against symlink shenanigans. This also makes the code a bit easier to follow. Discovered by Marc Herbert. Piggyback some minor cleanup. --- tests/symlink | 1 + 1 file changed, 1 insertion(+) create mode 120000 tests/symlink (limited to 'tests/symlink') diff --git a/tests/symlink b/tests/symlink new file mode 120000 index 0000000..565623e --- /dev/null +++ b/tests/symlink @@ -0,0 +1 @@ +sub/sub \ No newline at end of file -- cgit v1.2.3