From e5e2fe5a6f084fb98c2c9b4adec0383fec4a5256 Mon Sep 17 00:00:00 2001 From: Ulf Magnusson Date: Mon, 1 Jul 2019 22:52:17 +0200 Subject: Catch EnvironmentError instead of OSError/IOError menuconfig.py tended to crash on I/O errors on Python 2, due to forgetting to update some 'except OSError's. Catch EnvironmentError instead. EnvironmentError is a common base class of IOError and OSError on Python 2, and an alias for OSError on Python 3. Use it elsewhere too, as it might help catch obscure I/O errors on Python 2. --- guiconfig.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'guiconfig.py') diff --git a/guiconfig.py b/guiconfig.py index 9f72203..f3b17a0 100755 --- a/guiconfig.py +++ b/guiconfig.py @@ -1696,7 +1696,7 @@ def _try_save(save_fn, filename, description): _set_status(msg) print(msg) return True - except (OSError, IOError) as e: + except EnvironmentError as e: messagebox.showerror( "Error saving " + description, "Error saving {} to '{}': {} (errno: {})" @@ -1717,7 +1717,7 @@ def _try_load(filename): _set_status(msg) print(msg) return True - except (OSError, IOError) as e: + except EnvironmentError as e: messagebox.showerror( "Error loading configuration", "Error loading '{}': {} (errno: {})" -- cgit v1.2.3