From 0327db2e642800a1608b006cd6c569f7bca0ff5c Mon Sep 17 00:00:00 2001 From: Ulf Magnusson Date: Tue, 12 Jun 2018 01:58:41 +0200 Subject: Simplify allnoconfig.py and allyesconfig.py We can rely on set_value() being a no-op when setting non-bool/tristate symbols to 0/1/2 (due to those values being invalid for other types). Remove some long duplicated comments too. --- allyesconfig.py | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) (limited to 'allyesconfig.py') diff --git a/allyesconfig.py b/allyesconfig.py index ecc74ba..bf7ca51 100755 --- a/allyesconfig.py +++ b/allyesconfig.py @@ -36,22 +36,20 @@ import kconfiglib def main(): kconf = kconfiglib.standard_kconfig() - # Avoid warnings printed by Kconfiglib when assigning a value to a symbol that - # has no prompt. Such assignments never have an effect. + # See allnoconfig.py kconf.disable_warnings() - # Small optimization - BOOL_TRI = (kconfiglib.BOOL, kconfiglib.TRISTATE) - - # Try to set all bool/tristate symbols to 'y'. Dependencies might truncate - # the value down later, but this will at least give the highest possible - # value. + # Try to set all symbols to 'y'. Dependencies might truncate the value down + # later, but this will at least give the highest possible value. + # + # Assigning 0/1/2 to non-bool/tristate symbols has no effect (int/hex + # symbols still take a string, because they preserve formatting). for sym in kconf.defined_syms: - if sym.orig_type in BOOL_TRI: - # Set all choice symbols to 'm'. This value will be ignored for - # choices in 'y' mode (the "normal" mode), but will set all symbols - # in m-mode choices to 'm', which is as high as they can go. - sym.set_value(1 if sym.choice else 2) + # Set choice symbols to 'm'. This value will be ignored for choices in + # 'y' mode (the "normal" mode), which will instead just get their + # default selection, but will set all symbols in m-mode choices to 'm', + # which is as high as they can go. + sym.set_value(1 if sym.choice else 2) # Set all choices to the highest possible mode for choice in kconf.choices: -- cgit v1.2.3