From f356ba861432980c4a37279af51142b331c84aca Mon Sep 17 00:00:00 2001 From: Ulf Magnusson Date: Fri, 23 Nov 2018 10:39:15 +0100 Subject: Clarify that select/imply is a no-op for choice symbols The warning for selecting/implying a choice symbol could be misunderstood as saying that select/imply has no effect on choice symbols in a particular case. Select/imply never has an effect on choice symbols though. Rephrase the warning to make it clearer. --- kconfiglib.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kconfiglib.py b/kconfiglib.py index 5a5659c..6a62ee6 100644 --- a/kconfiglib.py +++ b/kconfiglib.py @@ -3375,8 +3375,9 @@ class Kconfig(object): # parsing. Only generates errors and warnings. def warn_select_imply(sym, expr, expr_type): - msg = "the choice symbol {} is {} by the following symbols, which " \ - "has no effect: ".format(_name_and_loc(sym), expr_type) + msg = "the choice symbol {} is {} by the following symbols, but " \ + "select/imply has no effect on choice symbols" \ + .format(_name_and_loc(sym), expr_type) # si = select/imply for si in split_expr(expr, OR): -- cgit v1.2.3