| Age | Commit message (Collapse) | Author |
|---|
|
IOError() generates an OSError in Python 3.6. OSError does not have a
'message' attribute, which caused the following error when trying to add
the hint re. environment variables (the rest of the message was still
displayed):
AttributeError: 'OSError' object has no attribute 'message'
Use str(exception) instead, which seems to work for both Python 2 and
Python 3.
|
|
"Active user value" might have been a bit unclear. The symbol needs to
be visible.
|
|
Bit neater.
|
|
|
|
Easier to debug than a RecursionError.
Point out in the exception message that a common cause is environment
variables not being set correctly.
|
|
|
|
And rename it to _rec_invalidate_if_has_prompt(). Always used in this
way in practice.
|
|
Saves a tiny bit of bytecode too.
|
|
Implicit submenus are created after parsing, in _finalize_tree(), so the
parent can never be a symbol in _parse_block().
|
|
It's set to -1 in every return path, so we can just do it at the
beginning instead.
|
|
Choice symbols without prompts are pointless and probably nonexistent in
practice, so it's a bit silly to run the no-prompt optimization for
them.
Piggyback copyright year update.
|
|
Saves a tiny bit of bytecode too.
|
|
Already know the value.
|
|
|
|
Also switch to a faster local lookup for the second _T_HELP.
Micro-optimization -- shaves a % or two of the _tokenize() runtime. We
expect a token for valid Kconfig files, so the naming is still fine.
|
|
The Linux Kernel's merge_config.sh defaults to disabling warnings for
redundant assignments and has support for enabling them
specifically. This patch reproduces this behaviour in kconfiglib
except that we retaing kconfiglib's default behaviour of enabling the
warnings.
Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
|
|
Piggyback some cleanup and redundant comment removal.
|
|
Simpler.
I realized there's actually no need to follow the node pointers, since
menus and comments never generate output.
|
|
|
|
Oversight. SYMBOL_AUTO (env_var) being set indirectly clears
SYMBOL_WRITE (_write_to_conf) in sym_calc_value(). The .config case was
already fine due to an explicit env_var check.
Even non-visible env. symbols ended up in the header, due to
'option env' internally adding a default.
Disallow user values altogether on 'option env' symbols, even if
specified manually. This matches the C implementation. Add a warning
too.
|
|
Implement the generation of the C header file that mirrors the .config
files, commonly named autoconf.h.
Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
|
|
Not passing -p1 causes the root Makefile to be patched instead of
scripts/kconfig/Makefile, as discovered in
https://github.com/ulfalizer/Kconfiglib/issues/32.
|
|
|
|
s/_parsing_configs/_parsing_kconfigs/
|
|
Already have the parent in 'parent'.
|
|
Rephrase it a bit too.
|
|
Fetching the next line is always followed by tokenization in practice
(outside of help texts), so things can be simplified a bit. Return
True/False to indicate EOF instead of returning the line.
|
|
Most common case. Make it cheap by storing the list of type tokens
separately instead of building the tuple each time through.
Shaves a few % off the runtime for property parsing.
|
|
|
|
Chained assignments turn a bunch of LOAD_CONSTs into DUP_TOPs. Shaves
~10% off the runtime of _lookup_sym().
Do the same for Choice.__init__(), just for consistency. Remove an
accidental duplicated assigment to 'defaults' too.
|
|
Similar to _get_assignable(). Cleaner than setting the cached value at
every 'return'.
|
|
IANAL, but hopefully this should be enough. Don't bundle the license
file. Might be easier to work with if just kconfiglib.py is copied.
|
|
The previous version would accept stuff like
'option env defconfig_list', due to how the tests were laid out.
|
|
|
|
The invalidation is necessary now that no global invalidation is done
before loading a .config.
|
|
Shaves a few % in line_profiler with no loss in readability.
Menus and comments are rare relatively speaking (~10% of all items
written out for alldefconfig), so optimize for the symbol case.
|
|
Bit less redundant.
|
|
Not needed anymore.
Just write the .config lines out directly. Saves creating the temporary
list. No detectable performance difference, positive or negative.
|
|
|
|
Avoiding global invalidation is much faster. There was just a lot of
redundant invalidation for promptless symbols going on when the comment
was first written.
|
|
Clean up some formatting a bit too.
|
|
Can use the magic .type attribute to check for modules being disabled.
Also remove note about infinite recursion. Pretty sure anything that
would cause infinite recursion here would be a proper circular
dependency (like MODULES depending on m).
|
|
Warnings for assignments to promptless symbols should be enabled
directly after Kconfig parsing. Braino from inverting the meaning of the
flag earlier.
The flag got properly reset after loading a .config.
|
|
Versions of properties without parent dependencies propagated aren't
saved anymore (though it'd be easy to add back if needed).
|
|
|
|
Add test coverage for that Choice.__repr__() path too.
|
|
|
|
Hit way too seldomly for it to make a performance difference, but a bit
neater. We know n, m, and y already exist since they're precreated.
|
|
Was only used by allyesconfig.py. Easy to add back if needed at any
point.
|
|
|
