| Age | Commit message (Collapse) | Author |
|
Need to manually set the mode of the choice now.
Dependencies get a huge workout just from lack of global invalidation,
so the manual dependency tests might be redundant. Would be tricky to
reuse the old tests as is too, so they would need to be restructured at
least.
|
|
Menus are plain menu nodes now, and those are exercised elsewhere.
|
|
Can just skip the invalidation for promptless symbols. Makes things less
magic and more intuitive while still being fast. Means no docs need to
be rewritten too.
Now the warning gets printed for unset_value() as well.
|
|
Return braino. Harmless but inconsistent (since the user value wasn't
set for promptless symbols when manually calling set_value()). Also
caused a lot of redundant invalidation.
Cuts test_defconfig() down to 2m32s from 3m00s with CPython, so skipping
global invalidation definitely pays off now.
Downside is you lose information on what value the .config had for the
symbol. Not sure if anyone would ever need that information (and it
should be simple to add if needed). It would usually match the actual
value of the symbol.
|
|
Kconfiglib already respects $srctree internally.
|
|
Looks like I already accidentally committed a partial update though...
Now prints ARCH again.
|
|
In replace mode, only unset symbols that didn't get set.
Get rid of _set_value_no_invalidate() and just do a normal set_value()
with invalidation. It's speedy with the new invalidation algorithm, and
simpler.
Not a big performance boost (but a small one), but means that
invalidation must be even more rock solid for the test suite to pass (no
global invalidations to hide behind), which is nice.
Also make y assignments to choice symbol update just the choice user
value. Gives nicer behavior when the choice mode is changed.
|
|
Dug into the C implementation to check exactly what's going on in those
weird corner cases. Improves compatibility slightly for defaults with
invalid values (though those are pretty clearly a bug and generate a
warning anyway).
|
|
|
|
|
|
_cached_vis is always calculated as a side effect of calculating any
other cached value, and so doubles as a flag for whether an item (symbol
or choice) has any cached values.
If _cached_vis is None for some item, it also indirectly means that no
other item can have any cached values that (actually) depend on the
item, because _cached_vis would have gotten calculated as a side effect
of calculating any such cached value. Therefore, it's safe to stop
recursive invalidation at an item that has _cached_vis None.
Huge speedup for the allyes/noconfig*.py scripts. allnoconfig_simpler.py
went from 2.671 seconds to 1.067 seconds.
The dependency selftests need to be updated too now that
_get_dependent() is gone. The kernel defconfig tests pass even if all
global invalidation is disabled at least (except for the few defconfigs
that don't set MODULES=y), and that's a huge invalidation test. Seems
pretty speedy too, even though there's some redundant work, so maybe
things could be simplified a bit...
|
|
Do not change the mode if y is assigned to a choice symbol inside a
choice in m mode, for example. Require Choice.set_value() to be called
instead.
This makes choices way less magical and more menuconfig-like. It would
also be confusing to be able to assign y to a choice symbol when y is
not in sym.assignable.
Set the mode manually in load_config() (y assigned to a choice symbol =>
y mode, and ditto for m). Change the warning for inconsistent values to
one that's probably less confusing, though the old one was closer to the
warning printed by the C implementation.
Need to fix a bunch of tests too...
|
|
Choice symbols get the choice itself propagated to the conditions of
their properties. This works since the Symbol/Choice value interfaces
are compatible now.
Simplifies value calculations and makes .assignable work automagically
for choice symbols in choices in any mode. One drawback is that a '&&
<choice>' now shows up on conditions when printing choice symbols, which
is not valid Kconfig. That should be easy to work around if needed at
least.
|
|
Make it public.
Piggyback some unrelated comment stuff due to git fails.
|
|
Also make the format in the code a bit more consistent.
|
|
Add some more details to the intro and various docstrings.
|
|
|
|
|
|
user_str_value isn't justified any more with the other API improvements.
user_value now stores 0, 1, 2 for bool/tristate symbols, and a string
for other symbol types. Much simpler and more intuitive.
Also avoid printing quotes around tristate values in __repr__(). This
was inconsistent too as it was only done for the value and user value.
Should be getting close to final API.
|
|
|
|
|
|
Handy and intuitive. Avoids having to go to .item all the time when
experimenting, and provides Kconfig output for menus and comments.
>>> print c.top_node
menu "Linux/$ARCH $KERNELVERSION Kernel Configuration"
>>> print c.top_node.list
config SRCARCH
string
option env="SRCARCH"
default "x86"
>>> print c.top_node.list.next
config 64BIT
bool
prompt "64-bit kernel" if ARCH = "x86"
default ARCH != "i386"
help
Say yes to build a 64-bit kernel - formerly known as x86_64
Say no to build a 32-bit kernel - formerly known as i386
Piggyback escaping when printing the prompt of symbols and choices. They
can contain " and \ as well.
|
|
|
|
|
|
To be consistent with the renamed class.
Piggyback docstring fixes.
|
|
Not worthwhile to confuse the API by allowing strings for bool/tristate.
Things works out nicely anyway with the other updated APIs.
|
|
Easier to work with, allowing e.g. direct comparisons with < and >. Make
set_value() take 0, 1, 2 for bool and tristate symbols, and fix other
APIs to match.
Also:
- Add introductions to various concepts in the module docstring.
Document some more attributes. Still TODOs.
- Rename the Config class to Kconfig.
- Escape " and \ in the name of constant symbols when printing them.
Also make the (un)escaping 100% consistent with how the C tools do
it (\ before non-magic character should be unescaped too).
- Clean up the escaping/unescaping code and provide two public
escape()/unescape() functions.
- Export the original MODULES-independent type in orig_type. It's
needed for printing symbols in the reparsable __str__() Kconfig
format with just public APIs.
- Lots of other minor reorganizing and nits all over.
|
|
|
|
|
|
Probably just some usability tweaks left. Having to do STR_TO_TRI[] for
comparisons against 'assignable' values is kinda ugly and confusing.
|
|
|
|
|
|
|
|
|
|
WIP
|
|
Get the symbol name without the '$' straight from the regex.
|
|
$FOO in 'source "$FOO"' refers to a Kconfig symbol rather than an
environment variable. Seems there might be some tools derived from the
kernel Kconfig implementation that work differently here.
|
|
|
|
Didn't even notice that it had become empty...
|
|
Clearer.
|
|
|
|
|
|
Add some micro-optimizations that speed up allyesconfig.py by 10-20%
with CPython. Clean up some minor stuff too.
|
|
Fixes an imply-related issue: 1774239 (Make 'imply' consider direct
dependencies). Imply support should be solid now.
|
|
Bad oversight. Weak reverse dependencies (from imply) are not considered
if the direct dependencies of a symbol are not met (the
'if'/'depends on' dependencies from the symbol and its parents, taking
location into account if the symbol is defined in multiple places).
Caused a wrong value for the symbol FS_FAT in the U-Boot Kconfigs, where
'imply' is more heavily used compared to the kernel.
Add a new variable _direct_deps that corresponds to dir_dep from the C
implementation. Before 'imply', dir_dep was only used for a
'select'-related warning in the C implementation.
Add a bunch of tests to cover 'imply' semantics. Should be solid now.
|
|
Also be a bit more consistent in how property variables are ordered.
|
|
The only fix is 2a2fcbd (Propagate dependencies to range conditions),
which fixes an obscure issue with dependencies on 'range x y'
properties.
Also includes some internal cleanup and optimization.
|
|
Just like for other properties, conditions on ranges get local
'depends on' and parent dependencies propagated to them. Oversight.
Did not trigger any deviations for the kernel defconfigs. Pretty
specific circumstances were required for breakage, like a symbol
depending on the particular value of a symbol with a 'range' and parent
deps 'n', or a symbol with ranges being defined in multiple locations
with different parent deps.
(There is one symbol that both has ranges and is defined in multiple
locations: BCH_CONST_M. The second definition adds a default rather than
a range though.)
|
|
Slightly modifying _STRING_LEX allows the (common) symbol reference case
to be detected earlier and removes some assignments.
Also modify some comments and air things out a bit.
|
|
Calculate as needed instead, using _get_expr_syms(). Simplifies the
parsing code.
Also rename _get_expr_syms*() to _expr_syms*() and make it append to a
list. Handy for the new way it's being used.
|