| Age | Commit message (Collapse) | Author |
|---|
|
When using gsource with $srctree set to an absolute path, the $srctree
prefix would show up in MenuNode.filename, trickling its way into e.g.
generated documentation.
This was due to a broken test: os.path.isabs() was checked after joining
the pattern with $srctree, making it mistake an absolute $srctree for an
absolute path in the Kconfig file.
Fix the test.
|
|
This release improves performance for projects that make heavy use of
multiple definition locations for symbols, via commit 747e455
("Massively speed up U-Boot parsing").
Two new warnings are included as well:
- 652d991 ("Warn if int/hex/string symbols are evaluated logically")
- 21b5351 ("Warn if int/hex 'default' is outside active 'range'")
|
|
U-Boot has a ton of definition locations for some symbols, causing a lot
of redundant work when iterating over Kconfig.defined_syms in
_build_dep(). Iterate over set(Kconfig.defined_syms) instead, wherever
possible.
This speeds up the U-Boot parsing time from 4 seconds to 0.6 seconds on
my machine.
Also update the bundled tools to iterate over set(Kconfig.defined_syms).
The performance loss is negligible even for projects that don't use
multiple definition locations.
Update the documentation to clarify that symbols/choices defined in
multiple locations appear multiple times in Kconfig.defined_syms/choices
as well.
|
|
|
|
More environment variables are referenced now.
|
|
|
|
Only out-of-range user values generated warnings before.
The C tools warn for neither of them.
|
|
They always evaluate to n.
Would be nice if there was a trivial way to give the location(s). Just
say "somewhere" for now.
|
|
New features:
- 2433deb ("Add Kconfig preprocessor") implements a new Kconfig
preprocessor, documented in
https://github.com/torvalds/linux/blob/master/Documentation/kbuild/kconfig-macro-language.txt.
It is required to parse the linux-next Kconfigs now, and will appear
in Linux 4.18.
'option env=...' symbols and the $FOO syntax for expanding
environment variables will be supported for backwards compatibility
for a while. Consider switching to $(FOO) though, which is the new
syntax (and removing 'option env=...' symbols).
Changed behavior:
- c19fc11 ("Drop some compatibility and tighten up lexing") makes
Kconfiglib flag invalid characters in Kconfig files as a syntax
error in all context. They were previously ignored in some places
for compatibility with old sloppy versions of the C tools.
The C tools fixed it with commit c2264564 ("kconfig: warn of
unhandled characters in Kconfig commands") in July 2015. Older
kernels might require fixing up the Kconfig files a bit now.
New warnings:
- 4200e25 ("Generalize select-with-unsatisfied-deps warning") makes
the select-with-unsatisfied-dependencies warning trigger when a
symbol with m-valued direct dependencies is y-selected.
|
|
Has been removed (and is now always on).
|
|
Implement the Kconfig preprocessor described in
https://github.com/torvalds/linux/blob/master/Documentation/kbuild/kconfig-macro-language.txt
(which is now in linux-next and will appear in Linux 4.18).
A new Kconfig.variables property holds all the preprocessor variables so
that they can be inspected programmatically. Preprocessor variables are
represented by a new Variable class.
With the preprocessor, environment variables are referenced with $(FOO)
instead of $FOO. For backwards compatibility, $FOO is accepted as well
for now (and leaves "$FOO" as-is if FOO doesn't exist). The $FOO syntax
might be dropped at some point in the future (together with a major
version increase). It should be supported for a few months at least.
Some internals were cleaned up too, mostly related to parsing. Some
outdated documentation was fixed as well.
|
|
y-selecting a symbol with direct dependencies m should be flagged as
well. Mirrors a change to the C tools.
|
|
Have _tokenize() take the string to tokenize and return a list of
tokens, and handle all the token list management outside.
Simplifies the internal logic a bit. Likely faster too.
|
|
|
|
|
|
Things like 'choice NAMED_CHOICE oops extra tokens' and 'choice &&' are
now detected as syntax errors.
Bit faster too, though it doesn't matter here.
|
|
This makes all tokens except empty strings truthy, getting rid of some
'is (not) None' checks.
|
|
Old versions of the C tools used to ignore unhandled characters in some
contexts due to sloppy lexing, which Kconfiglib emulated for
compatibility (things like "---help---" used to depend on it).
This was improved in the C tools by commit c2264564 ("kconfig: warn of
unhandled characters in Kconfig commands"), committed in July 2015.
Remove the compatibility hack and tighten up the lexing in Kconfiglib as
well. It will make implementing the new preprocessor stuff smoother.
The major version will be bumped.
|
|
|
|
The _update_menu() call at the end of _change_node() is redundant,
because _set_val() already calls _update_menu() if the value changes
|
|
|
|
More common style.
|
|
Wrong indentation, unused imports.
|
|
All three act on the currently selected node, so the code that fetches
it can be moved into the helper function.
|
|
|
|
Much of the functionality is available in Kconfiglib itself now. Use the
new APIs to implement the examples in a much simpler way.
|
|
New features:
- db92bb7 ("Add dependency loop detection") adds long-overdue
dependency loop detection.
Previously, dependency loops would trigger hard-to-debug Python
RecursionError exceptions during evaluation. They now generate a
KconfigError instead, with a helpful message that shows the items in
the loop.
Backwards-incompatible changes (major version bumped to 7):
- eb6c21a ("Turn MenuNode/Symbol/Choice.referenced() into a
@property") fixes some inconsistency in the recently-added
referenced-symbols APIs. Oversight.
Other changes:
- f6eb4f4 ("Add Symbol/Choice.referenced() convenience methods")
makes it easier to get all the symbols/choices referenced by a
symbol or choice. Previously, you'd have to loop through all the
menu nodes (definition locations) yourself, which might not be
obvious.
- ca89ca0 ("Rename KconfigSyntaxError to KconfigError") changes to
a better exception name, as KconfigSyntaxError was raised for some
things that aren't syntax errors.
The old name is kept as an alias for now for backwards
compatibility.
|
|
Having it as a function is inconsistent, since all other read-only
fields use properties. Oversight.
Major version will be bumped to 7, though the function version wasn't in
for long.
|
|
Returns the union of the MenuNode.referenced() sets for all the menu
nodes of the symbol/choice.
|
|
Can get the initial set from expr_items(self.dep), since it's always
included and always returns a new set().
|
|
This exception is generated for semantic errors and e.g. when dependency
loops are detected as well, so the name is bad.
Keep the old name as an alias for now for backwards compatibility.
|
|
Pretty long overdue.
Until now, dependency loops have raised a hard-to-debug Python
RecursionError during evaluation. A Kconfiglib exception is raised now
instead, with a message that lists all the items in the loop.
See the comment at the start of _check_dep_loop_sym() for an overview of
the algorithm. At a high level, it's loop detection in a directed graph
by keeping track of unvisited/visited nodes during depth-first search.
(A third "visited, known to not be in a dependency loop" state is used
as well.)
Choices complicate things, as they're inherently loopy: The choice
depends on the choice symbols and vice versa, and the choice symbols in
a sense all depend on each other.
Add the choice-to-choice-symbol dependencies separately after dependency
loop detection, so that there's just the choice-symbol-to-choice
dependencies to deal with. It simplifies things, as it makes it possible
to tell dependencies from 'prompt' and 'default' conditions on the
choice from choice symbol dependencies.
Do some flag shenanigans to prevent the choice from being "re-entered"
while looping through the choice symbols. Maybe this could be cleaned up
a bit somehow...
Example exception message:
Dependency loop
===============
A (defined at tests/Kdeploop10:1), with definition...
config A
bool
depends on B
...depends on B (defined at tests/Kdeploop10:5), with definition...
config B
bool
depends on C = 7
...depends on C (defined at tests/Kdeploop10:9), with definition...
config C
int
range D 8
...depends on D (defined at tests/Kdeploop10:13), with definition...
config D
int
default 3 if E
default 8
...depends on E (defined at tests/Kdeploop10:18), with definition...
config E
bool
(select-related dependencies: F && G)
...depends on G (defined at tests/Kdeploop10:25), with definition...
config G
bool
depends on H
...depends on the choice symbol H (defined at tests/Kdeploop10:32), with definition...
config H
bool
prompt "H" if I && <choice>
depends on I && <choice>
...depends on the choice symbol I (defined at tests/Kdeploop10:41), with definition...
config I
bool
prompt "I" if <choice>
depends on <choice>
...depends on <choice> (defined at tests/Kdeploop10:38), with definition...
choice
bool
prompt "choice" if J
...depends on J (defined at tests/Kdeploop10:46), with definition...
config J
bool
depends on A
...depends again on A (defined at tests/Kdeploop10:1)
|
|
|
|
Largely paid work, and it's copied into Zephyr, so it was a request.
All other source files are still copyright me.
Nothing changes in practice. I went for shared copyright to make sure
the ISC license can never be changed.
|
|
|
|
The properties themselves aren't really copied, just added to the
Symbol/Choice property lists.
|
|
|
|
More descriptive. Menu node properties are copied, not just their
dependencies.
|
|
Base 10 is the default.
|
|
Just adds commit dc0b022 ("Correctly report choice locations in some
warnings").
|
|
Menu nodes were added to choices after parsing their properties, making
some warnings generated during parsing (as opposed to in
_check_choice_sanity()) incorrectly give the choice as '<choice>
(undefined)'.
Add the node before parsing choice properties to fix those warnings.
|
|
.format() will implicitly format the exception as a string.
|
|
Fixes:
- c880151 ("Fix incorrectly ordered properties for some nested
multi.def. symbols") fixes a bug that could cause symbols/choices
defined in multiple locations and nested in particular ways within
if's and menus to get their properties in the wrong order.
The Linux kernel wasn't affected (which is how it managed to slip
through), but projects that make heavy use of symbols defined in
multiple locations might have been. Comprehensive selftests have
been added to cover property ordering on nested multi.def.
symbols/choices.
New features:
- 4af3e0c ("menuconfig: Support starting a search from the info
dialog") and 330017a ("menuconfig: Support viewing symbol info from
within the jump-to dialog") makes working with the menuconfig a bit
smoother to work with.
- 68043b2 ("Add MenuNode function that returns referenced items")
makes it easier to find out what symbols/choices a symbol, choice,
menu, or comment references, which is handy e.g. for searching.
|
|
|
|
This case wasn't covered.
|
|
The property lists weren't created for Kconfig.top_node, making
referenced() crash.
Add a MenuNode constructor and create the property lists there instead
of in _parse_properties().
|
|
_propagate_deps() visits menu nodes roughly breadth-first, meaning
properties on symbols and choices defined in multiple locations could
end up in the wrong order when copied from the menu node for some
unlucky if/menu nestings.
Fix it by moving the menu-node-to-symbol/choice property copying in
_finalize_tree() so that it's guaranteed to happen in definition order.
This bug was introduced by commit 63a4418 ("Record which MenuNode has
each property").
|
|
MenuNode.referenced() returns all symbols (and choices, for choice
symbols) referenced in the properties (prompt, defaults, selects,
ranges, etc.) and property conditions of the menu node.
Handy e.g. when generating cross-references.
|
|
|
|
Same cleanup as for _make_depend_on().
Rename 'deps' to 'res' as well. The result can be used for other stuff
besides figuring out dependencies.
|
