Kconfiglib.git/menuconfig.py, branch v10.47.0 Fork of https://github.com/zephyrproject-rtos/Kconfiglib.git https://git.mcdonnell.dev/Kconfiglib.git/atom?h=v10.47.0 2019-04-17T13:13:31Z menuconfig: Prune _shown_nodes() recursion 2019-04-17T13:13:31Z Ulf Magnusson ulfalizer@gmail.com 2019-04-17T12:43:06Z urn:sha1:a47615f06ad7e4d84ca1ab01db0520ef5f30010c When looking for visible children of invisible symbol nodes, _shown_nodes() was always recursing all the way out the leaf nodes. That's a ton of redundant work, though it doesn't seem to have lead to noticeable slowness (it does in the GUI menuconfig). Stop the search at symbol nodes with node.dep = n (from 'if'/'depends on'). Those can never have visible children, because node.dep gets propagated to prompts. menuconfig: Style nit 2019-04-17T03:16:22Z Ulf Magnusson ulfalizer@gmail.com 2019-04-17T03:15:55Z urn:sha1:e4f268157254df1ef361763bcfdf0258818fa53d Shorten a bit. menuconfig: _select_imply_info() style nit 2019-04-17T01:45:08Z Ulf Magnusson ulfalizer@gmail.com 2019-04-17T01:28:17Z urn:sha1:498f0edd8a0312f8a08b9b2be5b6b84e462fa7a7 menuconfig: Micro-optimize incremental search 2019-04-17T01:45:08Z Ulf Magnusson ulfalizer@gmail.com 2019-04-17T01:42:17Z urn:sha1:fb1bbb8aa5b1b5f60ecd055ee944b2ffefc22d5a removing the matches.append lookup saves a few %, as measured with line_profiler. It's fast enough already on any reasonable machine, so it's a bit silly, but it's pretty trivial. menuconfig: _jump_to_dialog() comment nits 2019-04-17T01:26:08Z Ulf Magnusson ulfalizer@gmail.com 2019-04-17T01:25:40Z urn:sha1:899bc77d837e9a2098449bd104bc640d99619194 Make things a bit more compact. menuconfig: Add missing 'return' in _select_selected_choice_sym() 2019-04-17T01:21:34Z Ulf Magnusson ulfalizer@gmail.com 2019-04-17T01:21:34Z urn:sha1:13dda5843f79a02f2c6dadc6cfd99ca62679dde3 Won't affect behavior, but it was intended. menuconfig: Fix display issue for optional-prompt menuconfigs 2019-04-17T01:10:01Z Ulf Magnusson ulfalizer@gmail.com 2019-04-17T00:06:59Z urn:sha1:37c698413ef6f433f03589a4f52076893030a9e5 _shown_nodes() needs to check whether invisible 'menuconfig' symbols with optional prompts have visible children, so that they can be shown outside show-all mode. Previously, only 'config' symbols were checked. menuconfig: Simplify _menu_path_info() 2019-04-11T20:26:23Z Ulf Magnusson ulfalizer@gmail.com 2019-04-11T20:26:23Z urn:sha1:8ddc0df484a25f915591c5bee6f4a9e4e71207d5 menuconfig: Include all parents in menu paths 2019-04-11T19:10:09Z Ulf Magnusson ulfalizer@gmail.com 2019-04-11T18:17:22Z urn:sha1:136c0e42f01dc3adfa29fb57f34f7d23234b8429 Previously, symbols not defined with 'menuconfig' with children weren't listed in the children's menu paths. It was deliberate, but it's probably an anti-feature in retrospect, because it can make it harder to find stuff by following the menu path. Don't try to be clever and just list all the parent nodes in the menu path. menuconfig: Rename _try_set_locale() to try_set_locale() 2019-04-10T23:07:07Z Ulf Magnusson ulfalizer@gmail.com 2019-04-10T23:07:07Z urn:sha1:f7c19d5ab4d5e13f25054b546fc93cc467aab0e1 This function isn't defined at the module level.