Fork of https://github.com/zephyrproject-rtos/Kconfiglib.git https://git.mcdonnell.dev/Kconfiglib.git/atom?h=v10.29.0 2018-11-28T14:37:50Z 2018-11-28T14:37:50Z Ulf Magnusson ulfalizer@gmail.com 2018-11-28T14:34:52Z urn:sha1:3d9217b5c021f5bd8e35b09eedfba8121aa051b1 One thing that irks me a bit about it is that it might give the idea that menuconfigs have to include it, making things seem more complex than they really are. 2018-11-28T14:12:16Z Ulf Magnusson ulfalizer@gmail.com 2018-11-28T14:12:16Z urn:sha1:38dff36b0f97b8c87bc95f18fce2c8d7d5a860d5 The thing it's talking about usually happens when some file with a named choice is included multiple times with different dependencies. 2018-11-28T14:04:18Z Ulf Magnusson ulfalizer@gmail.com 2018-11-28T14:04:18Z urn:sha1:f95ac89944bdca833c5398967c274ab520c2ce7b 2018-11-28T13:48:25Z Ulf Magnusson ulfalizer@gmail.com 2018-11-28T13:48:25Z urn:sha1:b3f0061c61da5c9dd604e580e6f220c4a7bd44fa When a Kconfig file defined a named choice and was included multiple times, the choice symbols were listed multiple times in the menuconfig as well (due to commit 17d7c1e ("menuconfig: Show all symbols at each menu location for multi.def. choices")). That's probably not what you want. Tweak it so that each symbol is only shown once, with the prompt that was used for it at whatever choice definition location is entered. Also change how the choice selection is displayed before the choice is entered, so that the prompt used for the selected symbol at that particular location is used. Previously, the prompt at the first definition location for the symbol was always used. (Note that all of this is only about how things are displayed. It's not essential to functionality, in case you're writing your own menuconfig.) 2018-11-21T04:45:19Z Ulf Magnusson ulfalizer@gmail.com 2018-11-21T04:45:19Z urn:sha1:a5721347075f3855d17a2dc96ff9b099025c1223 They're either proper menus, choices, or 'menuconfig' symbols. 2018-11-21T04:36:40Z Ulf Magnusson ulfalizer@gmail.com 2018-11-21T04:36:40Z urn:sha1:ee254891063a190c256f6f622311e622811d110b This matches the C tools and is a bit less spammy. Maybe it's less clear what it means at a glance, but it's probably less confusing for disabled 'menuconfig' symbols at least. 2018-11-18T17:58:16Z Ulf Magnusson ulfalizer@gmail.com 2018-11-18T16:41:30Z urn:sha1:df61771a449a1ca6ed7704e3aed3496063a47910 When scroll > max_scroll (blank space at the bottom of the menu, and also scrolled down), moving the cursor down would snap the scroll back to max_scroll, with a small annoying jump. This could happen when going into show-all mode and moving the cursor down near the bottom of a menu, for example. Fix it by leaving the scroll as-is when scroll >= max_scroll (increasing it by one otherwise). 2018-11-18T17:58:16Z Ulf Magnusson ulfalizer@gmail.com 2018-11-18T16:16:37Z urn:sha1:9a429a9abc1de8c431b42244be6e440d122c2686 Move the addition of the visible child nodes and use += instead of extend(). 2018-11-18T17:58:16Z Ulf Magnusson ulfalizer@gmail.com 2018-11-18T16:03:13Z urn:sha1:f5fd57c49ab7d858511de696409830ae53f85be7 Not noticeable performance-wise, but a bit neater. 2018-11-07T05:48:29Z Ulf Magnusson ulfalizer@gmail.com 2018-11-07T05:38:26Z urn:sha1:b810bdaf3c7ea436b78cb81fca4a1c5e1ff5079f Oversight. END can be handy for viewing all choices, menus, and comments, which appear at the end. Also support Ctrl-D as an alias for Page Down. Ctrl-U is already used by the edit box (erase to beginning of line). Also change the jump-to dialog title to hint that other things besides symbols can be jumped to.