Kconfiglib.git/menuconfig.py, branch v10.19.1

menuconfig: Fix crash when toggling symbols without a type

2018-11-02T02:53:02Z

Trying to toggle the following symbol crashed the menuconfig: config FOO prompt "foo" Symbols defined without a type are pointless and generate a warning (particular definition locations can omit the type, but some definition location should give a type if the symbol is defined in multiple locations). We should never crash for them though. Fix the crash. The code assumed that the symbol's current value would appear in Symbol.assignable, like for a visible bool/tristate, but symbols without types get their name as their value. Also skip printing "(NEW)" next to symbols without a type.

menuconfig: Add quotes around filename for .config loading errors

2018-11-01T00:02:32Z

Turns into a weird-looking 'Error loading ' otherwise. Maybe Enter should be ignored for empty filenames instead...

Make errno/strerror/filename available on IOError

2018-10-30T23:02:43Z

An error reporting flaw was that most raised IOErrors got their errno/strerror/filename fields stripped, due to wanting to show a custom messages. The problem was that adding back 'errno' and 'strerror' made IOError.__str__() always return a fixed string ("[Errno ] "), ignoring any custom message. This is friendly to users, but unfriendly to scripts (the menuconfig had a workaround). Make things friendly to both by raising an internal subclass of IOError instead, that preserves errno/strerror/filename but prints a custom message. The exception can then still be caught as IOError/OSError by scripts.

menuconfig: Mention jump-to in info dialog help

2018-10-22T20:42:36Z

Might be hard to discover that [/] works inside the info dialog otherwise.

menuconfig: Show the selected symbol for promptless choices

2018-10-21T05:09:56Z

If a choice is defined in multiple locations to add symbols, and show-all mode is turned on to reveal one of the promptless definitions, then it doesn't hurt to show the selected symbol next to it.

menuconfig: _node_str() simplification nit

2018-10-21T05:00:53Z

menuconfig: Use Kconfig.unique_choices in jump-to

2018-10-16T05:35:53Z

Use Kconfig.unique_choices instead of Kconfig.choices in the jump-to dialog, as choices defined in multiple locations should only get their menu nodes added once (to avoid redundant entries). I noticed a related Kconfiglib issue while working on this: Kconfig.choices has been identical to Kconfig.unique_choices all long, so things were never actually broken. That means Kconfig.choices should be fixed to match its description though. The next commit will do that.

menuconfig: Simplify _sorted_menu_comment_nodes()

2018-10-15T10:25:49Z

Can use the same function for both sort keys, and the logic can be simplified a bit too. The += is deliberate, to do in-place modification.

menuconfig: Fix some minor resizing jumpiness on gnome-terminal

2018-10-14T20:29:52Z

gnome-terminal jerks a bit whenever the terminal is shrunk so that the row with the cursor on it disappears. This is probably gnome-terminal shoddiness, but it's pretty easy to work around by drawing stuff at the top last, so do it. No need to do it for the jump-to dialog, because the cursor is already in the edit box at the top there.

menuconfig: Switch back to "very visible" cursor after Ctrl-F

2018-10-14T20:29:52Z

Was set back to "normal" instead due to a typo, which is inconsistent with the rest of the code.