Kconfiglib.git/kconfiglib.py, branch v7.0.0

Turn MenuNode/Symbol/Choice.referenced() into a @property

2018-06-22T04:02:47Z

Having it as a function is inconsistent, since all other read-only fields use properties. Oversight. Major version will be bumped to 7, though the function version wasn't in for long.

Add Symbol/Choice.referenced() convenience methods

2018-06-22T04:02:47Z

Returns the union of the MenuNode.referenced() sets for all the menu nodes of the symbol/choice.

Simplify MenuNode.referenced() a bit

2018-06-20T07:42:18Z

Can get the initial set from expr_items(self.dep), since it's always included and always returns a new set().

Rename KconfigSyntaxError to KconfigError

2018-06-19T22:16:16Z

This exception is generated for semantic errors and e.g. when dependency loops are detected as well, so the name is bad. Keep the old name as an alias for now for backwards compatibility.

Add dependency loop detection

2018-06-19T20:14:09Z

Pretty long overdue. Until now, dependency loops have raised a hard-to-debug Python RecursionError during evaluation. A Kconfiglib exception is raised now instead, with a message that lists all the items in the loop. See the comment at the start of _check_dep_loop_sym() for an overview of the algorithm. At a high level, it's loop detection in a directed graph by keeping track of unvisited/visited nodes during depth-first search. (A third "visited, known to not be in a dependency loop" state is used as well.) Choices complicate things, as they're inherently loopy: The choice depends on the choice symbols and vice versa, and the choice symbols in a sense all depend on each other. Add the choice-to-choice-symbol dependencies separately after dependency loop detection, so that there's just the choice-symbol-to-choice dependencies to deal with. It simplifies things, as it makes it possible to tell dependencies from 'prompt' and 'default' conditions on the choice from choice symbol dependencies. Do some flag shenanigans to prevent the choice from being "re-entered" while looping through the choice symbols. Maybe this could be cleaned up a bit somehow... Example exception message: Dependency loop =============== A (defined at tests/Kdeploop10:1), with definition... config A bool depends on B ...depends on B (defined at tests/Kdeploop10:5), with definition... config B bool depends on C = 7 ...depends on C (defined at tests/Kdeploop10:9), with definition... config C int range D 8 ...depends on D (defined at tests/Kdeploop10:13), with definition... config D int default 3 if E default 8 ...depends on E (defined at tests/Kdeploop10:18), with definition... config E bool (select-related dependencies: F && G) ...depends on G (defined at tests/Kdeploop10:25), with definition... config G bool depends on H ...depends on the choice symbol H (defined at tests/Kdeploop10:32), with definition... config H bool prompt "H" if I && depends on I && ...depends on the choice symbol I (defined at tests/Kdeploop10:41), with definition... config I bool prompt "I" if depends on ...depends on (defined at tests/Kdeploop10:38), with definition... choice bool prompt "choice" if J ...depends on J (defined at tests/Kdeploop10:46), with definition... config J bool depends on A ...depends again on A (defined at tests/Kdeploop10:1)

Rename _copy_props_to_sc() to _add_props_to_sc()

2018-06-15T00:43:48Z

The properties themselves aren't really copied, just added to the Symbol/Choice property lists.

Comment wording nit

2018-06-14T23:29:00Z

Rename _copy_deps_to_sc() to _copy_props_to_sc()

2018-06-14T22:54:54Z

More descriptive. Menu node properties are copied, not just their dependencies.

Correctly report choice locations in some warnings

2018-06-14T18:37:37Z

Menu nodes were added to choices after parsing their properties, making some warnings generated during parsing (as opposed to in _check_choice_sanity()) incorrectly give the choice as ' (undefined)'. Add the node before parsing choice properties to fix those warnings.

Remove redundant str()

2018-06-14T18:05:58Z

.format() will implicitly format the exception as a string.