Kconfiglib.git/kconfiglib.py, branch v4.2.0Fork of https://github.com/zephyrproject-rtos/Kconfiglib.githttps://git.mcdonnell.dev/Kconfiglib.git/atom?h=v4.2.02018-04-06T14:59:24ZMove sanity checking to after _finalize_tree()2018-04-06T14:59:24ZUlf Magnussonulfalizer@gmail.com2018-04-06T14:41:01Zurn:sha1:e8408a06c68d87485a9d45817dfdd60e722a6f1c
Previously, the warnings
warning: FOO (defined at Kconfig:1, Kconfig:6) defined with type unknown
warning: the default selection BAR (defined at Kconfig:9) of FOO (defined at Kconfig:1, Kconfig:6) is not contained in the choice
were printed for this (obscure, but okay) pair of definitions:
choice FOO
default BAR
endchoice
choice FOO
prompt "foo"
config BAR
bool "bar"
endchoice
The problem is that BAR is not known to be a choice symbol by the time
the first choice definition is encountered in _finalize_tree(), since
that's determined only when the second definition is encountered (it
needs to happen there, because implicit submenus can influence whether a
symbol is a choice symbol or not, and implicit submenus are determined
in _finalize_tree()).
Fix it by moving the sanity checks out of _finalize_tree() and into a
separate pass over all symbols and choices that runs after
_finalize_tree(). That might avoid other gotchas too.
Set is_menuconfig True on the top menu2018-04-05T07:03:15ZUlf Magnussonulfalizer@gmail.com2018-04-05T07:00:04Zurn:sha1:981d24aff765794f4ab440f29b1543a118222357
Oversight
Code consistency nit2018-04-04T15:30:02ZUlf Magnussonulfalizer@gmail.com2018-04-04T15:29:34Zurn:sha1:9c86dfd60273dc894da1db89220aff8d4de4716e
'is_menuconfig' is set after 'item' in the other cases.
Generalize is_menuconfig to non-symbol items2018-04-04T14:44:58ZUlf Magnussonulfalizer@gmail.com2018-04-04T14:20:58Zurn:sha1:2259d353426f12d5fa807075fb4727e64331ac8a
Extending the scope of is_menuconfig so that it's True for all items
whose children should be displayed in a separate menu turns out to be
handy when implementing menuconfig-like functionality.
Keep the old name for backwards compatibility. It's good enough.
Parenthesize && expressions within || expressions2018-03-28T18:29:20ZUlf Magnussonulfalizer@gmail.com2018-03-28T18:29:20Zurn:sha1:7245bad9ebb58fc8ce5a322081fc6c39d2dc59c6
This is redundant from an evaluation perspective, as && has higher
precedence than ||, but is easier to read.
A && B || C && D is now rendered as "(A && B) || (C && D)".
Use expr_str() to print selected/implied symbols2018-03-26T13:50:41ZUlf Magnussonulfalizer@gmail.com2018-03-26T13:30:44Zurn:sha1:a5ea0dcbc8b9343f6901654ad92de6ece156f954
This is redundant on its own, as only a single symbol can be
selected/implied, meaning just .name will work fine too. It means that
all symbols appearing in the __str__() representation of symbols and
choices are now printed via expr_str() though, which might come in handy
soon.
Refactor expr_str() cases2018-03-26T13:15:07ZUlf Magnussonulfalizer@gmail.com2018-03-26T13:12:09Zurn:sha1:6ef362c490bc2608c971eeabd5930ea0d8893dbe
- Detect Symbol directly instead of as (not tuple) + (not choice)
- Test explicitly for a tuple (non-Symbol) in NOT
- Add some tests to get better coverage for NOT and parentheses
Warn if a choice symbol is selected or implied2018-03-24T19:12:43ZUlf Magnussonulfalizer@gmail.com2018-03-24T18:32:12Zurn:sha1:225ec4bc3e6a2b88e14d58522494950d9c9e8236
This has no effect.
Model the warning on the one for selecting a symbol with unsatisfied
dependencies.
This is a Kconfiglib-exclusive warning so far.
_check_choice_sanity() style nit2018-03-24T17:54:02ZUlf Magnussonulfalizer@gmail.com2018-03-24T17:54:02Zurn:sha1:2195b37eb99f630a69e376d073cd58d3904b6420Rename _name_and_loc_str() to _name_and_loc()2018-03-24T02:34:09ZUlf Magnussonulfalizer@gmail.com2018-03-24T02:34:09Zurn:sha1:f82b052d14fa5171fd1dcac7b0abf5dbf0dd43a0
Bit shorter, still clear in context.