Kconfiglib.git/kconfiglib.py, branch v3.0.0Fork of https://github.com/zephyrproject-rtos/Kconfiglib.githttps://git.mcdonnell.dev/Kconfiglib.git/atom?h=v3.0.02018-02-08T09:14:48ZDon't special-case user_value for choice symbols set to y2018-02-08T09:14:48ZUlf Magnussonulfalizer@gmail.com2018-02-08T05:03:44Zurn:sha1:e8b4ecb6ff6ccc1c7be0818314fbccda2ef2b2ee
Previously, setting a choice symbol to y would only update
user_selection on the parent choice and not the symbol's own user_value.
Now both are updated.
The point of the old behavior was to remember the m mode selections of a
choice when it was switched back and forth between m and y mode, which
was a feature I thought the C implementation had. On closer inspection,
the C implementation never had that feature, though it might appear like
it if you only make "lucky" changes (if you never select any symbols in
y mode that were n in m mode).
The new behavior is simpler and easier to understand: Symbol.user_value
now always matches the value assigned in a .config file or via
set_value(), provided the value was well-formed. This might avoid some
special-casing in scripts too.
The loss in usability is pretty minimal.
Allow "n"/"m"/"y" as aliases for 0/1/2 in set_value()2018-02-07T02:55:56ZUlf Magnussonulfalizer@gmail.com2018-02-07T01:30:16Zurn:sha1:f66cd7155158943987570937be37b09d9ca58028
More experience working with the API convinced me that it's worth it.
Gets rid of ugly conversions in the menuconfig.py and oldconfig.py
examples, and streamlines some things internally as well.
Include two other small fixes as well:
- Make warnings generated by Choice.set_value() match those generated
by Symbol.set_value().
- Get rid of the input stripping in menuconfig.py. It's not like the
interface is usable as-is anyway, and it just complicates the
example.
Warn if choice symbol has prompt outside choice2018-01-30T09:46:38ZUlf Magnussonulfalizer@gmail.com2018-01-30T09:43:04Zurn:sha1:0eadd61c05c523a150721f9646e4d3f7cff58e5c
Defining a choice symbol in multiple places to add some properties to it
outside the choice seems to actually be done deliberately by MIPS, but
it's almost guaranteed to be an error if the definition(s) outside the
choice have a prompt (and so can be changed by the user there), so warn
for that.
Warn if a choice symbol has defaults2018-01-29T13:43:49ZUlf Magnussonulfalizer@gmail.com2018-01-29T13:43:31Zurn:sha1:3db12f728ec2d48640574133675bb01ca926d741
Never has en affect.
Warn if menuconfig statement has no prompt2018-01-29T13:26:01ZUlf Magnussonulfalizer@gmail.com2018-01-29T12:58:38Zurn:sha1:d43d2e83a9dc96d86dfbc946516bc3090303dbd3
Mirrors a warning in the C implementation.
Warn if help text is empty2018-01-29T12:36:41ZUlf Magnussonulfalizer@gmail.com2018-01-29T12:34:49Zurn:sha1:60d129111d8195eb61a010994e9fc974365a4d63
Personal pet peeve. Should add a warning to the C implementation too.
Refactor _check_sym_sanity()2018-01-29T10:56:28ZUlf Magnussonulfalizer@gmail.com2018-01-29T10:55:04Zurn:sha1:797221c4e39fbc584ba67c1bbecff383441923ff
Arrange by type, which works pretty neatly except for the pesky ranges
check. This also makes us do less work in the common BOOL/TRISTATE case.
Get rid of _check_select_imply_sanity().
Move sym.ranges check to end of _check_sym_sanity()2018-01-29T10:26:22ZUlf Magnussonulfalizer@gmail.com2018-01-29T10:26:22Zurn:sha1:92b1fcdd4bed1c3ee1bdbac5dccbb4f4baa447b7
More important stuff up front.
Warn if a symbol/choice has multiple prompts2018-01-29T09:48:45ZUlf Magnussonulfalizer@gmail.com2018-01-29T09:46:57Zurn:sha1:e930c140b424e4f72c6317bedef4ab45079270c9
In a single location. Having multiple definitions with different prompts
is okay.
Sanity-check range values2018-01-29T09:19:25ZUlf Magnussonulfalizer@gmail.com2018-01-29T08:26:58Zurn:sha1:ad94bb45ba5e1d36a9dcee3ebe7a4d65241379de
Must have a form compatible with the int/hex, like for defaults.
Also refactor a bit and use a single _int_hex_value_is_sane() helper.
Less duplication.