Kconfiglib.git/kconfiglib.py, branch v10.1.1

Fix recursive 'source' error reporting

2018-08-23T09:42:49Z

The recursive 'source' detection was still fine, but the error reporting had broken due a missed variable renaming. The test suite didn't catch it, because a different type of KconfigError was raised instead, due to a separate error in the test suite (need to include tests/Krecursive{1,2}, since paths are relative to $srctree). Fix the variable name and tighten up the tests to check that the KconfigError message is the one we except. Tighten up the dependency loop detection tests in the same way too.

Fix file descriptor leak for the top-level Kconfig file

2018-08-22T23:49:29Z

Needs to be close()d. The other Kconfig files are close()d in _leave_file(). Could drop the reference somehow too, but an explicit close() is best for PyPy, which doesn't do reference counting.

Flag extra tokens after 'if'/'depends on'/'visible if' expressions

2018-08-22T22:51:52Z

Extra trailing tokens after 'if ', 'depends on ', and 'visible if ' now trigger syntax errors instead of being ignored. Oversight. This indirectly makes Kconfig.eval_expr() detect extra trailing tokens as well.

Add a generic node iterator

2018-08-22T21:57:17Z

Suggested by Mitja Horvat (pinkfluid) in https://github.com/ulfalizer/Kconfiglib/pull/50. Kconfig.node_iter() iterates through all menu nodes in the menu tree in Kconfig order. This saves scripts the trouble of implementing their own tree walking code. Have node_iter() take a 'unique_syms' flag that can be enabled to only include symbols defined in multiple locations once. This is often what you want when generating output (and is used by write_config()). Order is still preserved. Piggyback a fix to a syntax error test comment. Parsing has been tightened up now.

Introduce Kconfig.unique_defined_syms and Kconfig.unique_choices

2018-08-22T18:05:11Z

These are the same as Kconfig.defined_syms and Kconfig.choices, except duplicates are removed. Kconfig order is still preserved. This is almost always what you want when iterating through symbols and choices, as it potentially saves work, avoids generating duplicates when writing output, and still preserves Kconfig order for readability. The old attributes will be kept for backwards compatibility (maybe there's some rare cases where they could be useful too). They're created internally anyway.

Merge Symbol._checked and Symbol._written

2018-08-21T19:17:45Z

These are never used at the same time, and Symbol._visited is a good name for both. Gets rid of an internal attribute.

Handle multiple definition locations in a nicer way

2018-08-21T18:45:27Z

Instead of precalculating a set() to get unique symbols, precalculate a list with any duplicates from multiple definition locations removed, and preserve the order of the symbols within it. This makes it possible to get rid of the Symbol._written shenanigans in functions that only need to iterate through unique symbols in sorted order, which is all of them except write_config() (because it needs to walk the entire menu tree).

Make auto.conf symbol order match .config symbol order

2018-08-21T14:36:28Z

Not likely that you'd need to inspect it, since it's more of an implementation detail of incremental builds, but it doesn't hurt.

Make header symbol order match .config symbol order again

2018-08-21T13:19:52Z

I accidentally broke this when I added the _defined_syms_set optimization. No semantic difference, but having the order match is more readable.

Refactor write_config() a bit

2018-08-21T12:26:37Z

Since the 'top_node' menu node itself is skipped, we can start from there and move the tree walk to the beginning of the loop. For an empty configuration (top_node.list set to None) the tree walk immediately discovers that there are no more nodes and returns.