Fork of https://github.com/zephyrproject-rtos/Kconfiglib.git https://git.mcdonnell.dev/Kconfiglib.git/atom?h=v10.20.0 2018-11-03T23:35:39Z 2018-11-03T23:35:39Z Ulf Magnusson ulfalizer@gmail.com 2018-11-03T23:35:39Z urn:sha1:3393d4ab948945bbf9fce6ab42f65dbfc8d14bc8 Adds a small menuconfig improvement: Commit 35af004 ("menuconfig: Move cursor to choice selection when entering choices"). 2018-11-03T23:33:43Z Ulf Magnusson ulfalizer@gmail.com 2018-11-03T22:08:01Z urn:sha1:35af0042e866eeed8eb2e05f8bbf2dd7b6d097f4 Previously, the first entry was selected, like for menus. Also tweak _center_vertically() so that the menu is never scrolled down when all entries fit on the screen. 2018-11-03T20:12:06Z Ulf Magnusson ulfalizer@gmail.com 2018-11-03T19:42:19Z urn:sha1:041a3de1e2d2399f338ec9a5ea4d07736adb9ad3 Set UNKNOWN (representing 'no type') to 0, which is falsy, to simplify some checks. Also reorder some dictionary keys for consistency. 2018-11-02T02:53:49Z Ulf Magnusson ulfalizer@gmail.com 2018-11-02T02:34:06Z urn:sha1:59edb3850575db74fb663942df37b8d87fe0cac8 Adds fixes for two obscure crashes, related to consecutive empty if's and toggling symbols without a type in the menuconfig: - Commit 0e6cd82 ("Fix removal of multiple consecutive 'if' nodes") - Commit db60270 ("menuconfig: Fix crash when toggling symbols without a type") 2018-11-02T02:53:02Z Ulf Magnusson ulfalizer@gmail.com 2018-11-02T02:18:28Z urn:sha1:db60270a2d498e59d76f072298aa9d45a03136f2 Trying to toggle the following symbol crashed the menuconfig: config FOO prompt "foo" Symbols defined without a type are pointless and generate a warning (particular definition locations can omit the type, but some definition location should give a type if the symbol is defined in multiple locations). We should never crash for them though. Fix the crash. The code assumed that the symbol's current value would appear in Symbol.assignable, like for a visible bool/tristate, but symbols without types get their name as their value. Also skip printing "(NEW)" next to symbols without a type. 2018-11-02T02:52:46Z Ulf Magnusson ulfalizer@gmail.com 2018-11-02T01:35:49Z urn:sha1:0e6cd82908f5c649e15e6a63ad77a94f627449d2 Despite 'if' nodes being flattened before 'if' removal, consecutive 'if' nodes can still show up for code like the following: ... if X endif if X endif ... _remove_ifs() failed to remove the second 'if' node, leading to a crash e.g. when turning on show-all mode in the menuconfig in a menu with such code (due to the unexpected 'if' node). Stuff like the above could potentially result from 'osource's with no matches, though I just spotted the error while looking over the code. Fix the 'if' removal logic to properly handle consecutive 'if' nodes. 2018-11-01T02:59:18Z Ulf Magnusson foo@bar.com 2018-11-01T02:53:34Z urn:sha1:b0e4a4fda7d623284ac1949d6797b9f0a1995d88 Adds commit 8be38f2 ("Don't show backtraces for expected exceptions in tools"), which hides backtraces for expected errors from tools (like Kconfig syntax errors and missing files). 2018-11-01T02:21:09Z Ulf Magnusson foo@bar.com 2018-11-01T01:48:30Z urn:sha1:8be38f27788239739619db86b6e5270ef7905511 KconfigError and IOError are part of normal operation and don't indicate a problem with the library itself. Catch and print them in standard_kconfig() and sys.exit(), to avoid spammy backtraces from e.g. menuconfig.py when Kconfig files don't exist or have errors. 2018-11-01T00:18:38Z Ulf Magnusson ulfalizer@gmail.com 2018-10-31T03:18:41Z urn:sha1:d30b55043c4c771cdabf42847cf718a93cf86ab8 Can get away with a single variable by assigning node.list earlier, and save a tiny bit of work with a chained assignment. Also clarify what the tricky Python chained assignments correspond to, where it matters. 2018-11-01T00:02:32Z Ulf Magnusson ulfalizer@gmail.com 2018-10-31T02:18:33Z urn:sha1:dbd07bb85db0448502ee51aa43ea6ca27b84ed45 Turns into a weird-looking 'Error loading ' otherwise. Maybe Enter should be ignored for empty filenames instead...