Fork of https://github.com/zephyrproject-rtos/Kconfiglib.git https://git.mcdonnell.dev/Kconfiglib.git/atom?h=v1.0.6 2017-10-01T22:21:53Z 2017-10-01T22:21:53Z Ulf Magnusson ulfalizer@gmail.com 2017-10-01T22:19:52Z urn:sha1:9f96f968a76ae573cc8e5b6ee5cf169b5badd40e Fixes an imply-related issue: 1774239 (Make 'imply' consider direct dependencies). Imply support should be solid now. 2017-10-01T22:07:51Z Ulf Magnusson ulfalizer@gmail.com 2017-10-01T18:01:08Z urn:sha1:1774239986d36f4894e7f59efd953f408cbbf80a Bad oversight. Weak reverse dependencies (from imply) are not considered if the direct dependencies of a symbol are not met (the 'if'/'depends on' dependencies from the symbol and its parents, taking location into account if the symbol is defined in multiple places). Caused a wrong value for the symbol FS_FAT in the U-Boot Kconfigs, where 'imply' is more heavily used compared to the kernel. Add a new variable _direct_deps that corresponds to dir_dep from the C implementation. Before 'imply', dir_dep was only used for a 'select'-related warning in the C implementation. Add a bunch of tests to cover 'imply' semantics. Should be solid now. 2017-10-01T06:34:28Z Ulf Magnusson ulfalizer@gmail.com 2017-10-01T06:33:15Z urn:sha1:009ce631d0ba2978f51d15b0b250276a078707e8 Also be a bit more consistent in how property variables are ordered. 2017-10-01T05:28:19Z Ulf Magnusson ulfalizer@gmail.com 2017-10-01T05:28:19Z urn:sha1:80279c463725971430b8f9410040966ed2e2b303 The only fix is 2a2fcbd (Propagate dependencies to range conditions), which fixes an obscure issue with dependencies on 'range x y' properties. Also includes some internal cleanup and optimization. 2017-10-01T04:52:31Z Ulf Magnusson ulfalizer@gmail.com 2017-10-01T04:28:02Z urn:sha1:2a2fcbd404878d539683178d98c67c983b5f61c9 Just like for other properties, conditions on ranges get local 'depends on' and parent dependencies propagated to them. Oversight. Did not trigger any deviations for the kernel defconfigs. Pretty specific circumstances were required for breakage, like a symbol depending on the particular value of a symbol with a 'range' and parent deps 'n', or a symbol with ranges being defined in multiple locations with different parent deps. (There is one symbol that both has ranges and is defined in multiple locations: BCH_CONST_M. The second definition adds a default rather than a range though.) 2017-10-01T00:50:29Z Ulf Magnusson ulfalizer@gmail.com 2017-10-01T00:09:34Z urn:sha1:ab58c2388128df0dfe361b7d1a795c520cbfa55d Slightly modifying _STRING_LEX allows the (common) symbol reference case to be detected earlier and removes some assignments. Also modify some comments and air things out a bit. 2017-09-30T20:12:48Z Ulf Magnusson ulfalizer@gmail.com 2017-09-30T18:46:02Z urn:sha1:2c062711d974be25346776fcb30ab1310cd896e2 Calculate as needed instead, using _get_expr_syms(). Simplifies the parsing code. Also rename _get_expr_syms*() to _expr_syms*() and make it append to a list. Handy for the new way it's being used. 2017-09-30T16:43:42Z Ulf Magnusson ulfalizer@gmail.com 2017-09-30T16:43:42Z urn:sha1:890e5b6bec0523a7de57ebb9c8fd4caa7c2c5905 Calculate as needed instead. Old cruft. 2017-09-30T16:09:37Z Ulf Magnusson ulfalizer@gmail.com 2017-09-30T16:08:39Z urn:sha1:11dc7657e2ddc615f38cc87c4c8ae6e1be939eba Calculate it as needed instead. It's not used internally. Also move get_referenced_symbols() to the Item base class, as the logic is identical for symbols/choices/menus/comments. Finally a non-silly use for it. 2017-09-30T15:43:10Z Ulf Magnusson ulfalizer@gmail.com 2017-09-30T04:13:00Z urn:sha1:9a622874419fac263c32f55786760a266a7f7f32 - Menu/Comment._dep_expr and Symbol/Choice._menu_dep are really the same thing internally in the C implementation (the dependency for the "menu node", which is also used to implicitly create menus), and it simplifies the code to treat them like that here too. - Reuse the calculated _menu_dep (which has parent and 'depends on' dependencies) when propagating dependencies to properties. - Get rid of the temporary lists. It's now easy to use plain 'for' loops to add the properties. - Catch attempts to use select/imply from menus and choices early and error out. - Add comments clarifying which variables are only used when displaying items.