Kconfiglib.git, branch v1.0.3

Make 1.0.3 release

2017-09-27T15:21:16Z

Fixes two minor issues that didn't trigger for the kernel defconfigs but were found by inspecting the Kconfig C sources: - 5f3d307 (Fix 'default' on non-visible choice symbols) - f76a524 (Hide non-tristate symbols in non-y tristate choices) Also includes some minor optimizations and a lot of code cleanups, including prefixing all internal identifiers with _.

Warn if the Makefile patch hasn't been applied

2017-09-27T15:08:30Z

The old error from the test suite was cryptic.

Hide non-tristate symbols in non-y tristate choices

2017-09-27T15:08:15Z

There's old ad-hoc code that does this in the C implementation, added in f5eaa32 (kconfig: tristate choices with mixed tristate and boolean values). Unless a tristate choice is in "y" mode, non-tristate symbols get visibility "n". There are currently no tristate choices with non-tristate symbols in the kernel, so this never triggered. Modify some self tests that weren't aware of this behavior, and add some new ones. Also remove an old pointless test.

Micro-optimize _tokenize()

2017-09-26T19:56:28Z

- A small modification to _initial_token_re_match makes it reject comments too, saving some manual code (and probably lots of string copying). - Reorganize things to handle 'previous' in a nicer way. - Use tuples instead instead of lists in the no-tokens and _T_HELP cases. Could preallocate and return an empty _Feed too, but it seems like overkilling it. Profiling done with cProfile and line_profiler.

Simplify Symbol._make_conf() conditional

2017-09-26T15:19:47Z

Fix 'default' on non-visible choice symbols

2017-09-25T18:42:44Z

Previously, 'default CHOICE_SYM [if ]' in a choice would skip any following 'default' properties if was non-'n'. However, those other defaults should still be considered if CHOICE_SYM has visibility 'n'. Previously, we'd immediately fall back to selecting the first visible symbol in the choice in that case. get_selection_from_defaults() now exactly mirrors sym_choice_default() from the C implementation, and got less convoluted too. Nothing in the kernel defconfigs triggered this. Add a new test case too.

Remove redundant str()

2017-09-25T17:29:36Z

Remove unhelpful invalidation comments

2017-09-25T17:29:23Z

Probably not worthwhile to do anything overly fancy in the mentioned cases. Add some more helpful comments instead. Piggyback another comment nit.

Don't set defaults that will always be overwritten

2017-09-25T16:21:34Z

The constructors previously defaulted all properties. This is dead code for properties that are always set on items from outside during parsing, and obfuscates the code flow and wastes time. Instead, just mention other properties that exist in comments in the constructors. Also add test cases for missing and empty 'choice' help texts. Removing the default 'self._help = None' assignment in Choice.__init__() wasn't caught by the selftests.

Rename _sym_lookup() to _lookup_sym()

2017-09-25T13:54:09Z